Repository navigation
chore(macos): day view column UTC boundary parity (follow-up to #5229) - #5232
Open
tyler-dane wants to merge 7 commits into
Open
tyler-dane wants to merge 7 commits into
tyler-dane wants to merge 7 commits into
Conversation
Document follow-up to align native isTimedEventOnDay with web query-window overlap. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Match web #5229 by overlapping timed events with dayEventQueryRange instead of civil-day start matching; add boundary XCTest and optional anchor timezone. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Round-tripping query-window strings through parseInEffectiveTimeZone dropped Denver-boundary matches; use dayEventQueryBounds directly. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Pick provider zones when effective is UTC-like, wire hint in rebuildPresentation, and regression-test via dayViewCalendarsForLayout at the Nov 12 UTC boundary. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
…mn-tz-parity-0084 Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Mirror web pin-then-hint-then-browser resolution so fetch windows, anchors, and day columns share one zone; drop the DayCalendarColumns side channel. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Set EffectiveTimeZone before the first sundayWeekViewStart, re-anchor when a calendar hint changes the effective zone, and mirror web by picking the hint from the full calendar list rather than visible rows only. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
macOS parity for web calendar timezone hint (
pin ?? hint ?? device). Reviewer confirmed the ViewStore chain matches web.Must-fixes in latest push:
EffectiveTimeZone.identifierto pin/device/demo before initialsundayWeekViewStart; re-anchor week + refresh visible range when hint changes effective zone.calendarslist (notvisibleCalendars()), matching webpickCalendarTimeZoneHint.Verify
ViewStoreCalendarTimeZoneTests,DayCalendarColumnsTests, newNativeCalendarRootModelInitialWeekAnchorTests,CalendarTimeZoneHintTests.Not ready for merge until reviewer re-approves after CI on head.